Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ImageID resolution in DockerProcessor #34361

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Remove unnecessary ImageID resolution in DockerProcessor #34361

merged 2 commits into from
Jun 29, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 28, 2023

The process is longer used for anything except logging
and it doesn't even work properly with new Docker versions
as the output has changed

For example, a run I did yielded:

[INFO] [io.quarkus.container.image.docker.deployment.DockerProcessor] Built container image gandrian/getting-started-command-mode:1.0.0-SNAPSHOT (null)

because my Docker version no longer has the line starting with Successfully built.

P.S. The first commit isn't strictly necessary, but I think we should include it as it both fixes the default logging of ExecUtil
and also removes an unused and unsafe API

@geoand geoand requested a review from iocanel June 28, 2023 08:21
@quarkus-bot

This comment has been minimized.

Sign in to view
iocanel
iocanel approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I would like things like Image Id etc as build items that could be passed all the way up to the CLI. Till then let's remove that and we can bring it up when we are ready to actually use them.

geoand added 2 commits June 29, 2023 10:19
@geoand
Cleanup ExecUtil API
f10a136 
* Fix INFO_LOGGING
* Remove the unused global logging settings
@geoand
Remove unnecessary ImageID resolution in DockerProcessor
1306867 
The process is longer used for anything except logging
and it doesn't even work properly with new Docker versions
as the output has changed
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 29, 2023

Failing Jobs - Building 1306867

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
⌛ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 100 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

@geoand geoand merged commit 44acbf2 into quarkusio:main Jun 29, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jun 29, 2023
@geoand geoand deleted the docker-log branch June 29, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @iocanel